Feat: Implement a basic Zotero picker compatible CAYW endpoint#13185
Feat: Implement a basic Zotero picker compatible CAYW endpoint#13185koppor merged 58 commits intoJabRef:mainfrom
Conversation
jabsrv/src/main/java/org/jabref/http/server/cayw/CAYWResource.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchDialog.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchDialog.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Great progress so far, Philip!
I have left some comments.
Also, if possible, please add javadoc to every non-trivial method you write during the project (by non-trivial I mean ones which are not getX, setZ or displayP etc.) so that any maintainer taking a walk can review your code easily without having to gather context.
^This suggestion holds for all GSoC students @Yubo-Cao @Kaan0029 @wanling0000.
jabsrv/src/main/java/org/jabref/http/server/cayw/CAYWResource.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/CAYWResource.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/CAYWResource.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/CAYWResource.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchResultContainer.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchResultContainer.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SearchResultContainer.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SelectedItemsContainer.java
Outdated
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/cayw/gui/SelectedItemsContainer.java
Outdated
Show resolved
Hide resolved
|
Tmp moved to JabRef#709 |
|
|
||
| /// @return a stream to the `Chocolate.bib` file in the classpath (is null only if the file was moved or there are issues with the classpath) | ||
| private @Nullable InputStream getChocolateBibAsStream() { | ||
| return BibDatabase.class.getResourceAsStream(CHOCOLATEBIB_PATH); |
There was a problem hiding this comment.
Method can return null but doesn't use Optional to explicitly handle the null case, violating the principle of not returning null from public methods.
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
|
@trag-bot didn't find any issues in the code! ✅✨ |
1 similar comment
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
JUnit tests of You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
Adds the ability to use the extensions which normally can be used with better-bibtex to startup the cayw citation picker in zotero.
Closes #13187
The cayw endpoint and gui can be opened with
after that it opens up a window where you can search
Provide path to bif file - and say JSON format
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)